Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

feat: convertion operations #431

Merged
merged 13 commits into from
Nov 11, 2022
Merged

feat: convertion operations #431

merged 13 commits into from
Nov 11, 2022

Conversation

arthurbleilzup
Copy link
Contributor

@arthurbleilzup arthurbleilzup commented Oct 21, 2022 •
edited
Loading

Related Issue: ZupIT/beagle#1823

@arthurbleilzup
feat: convertion operations
4538c70 
Signed-off-by: Arthur Bleil <[email protected]>
Tiagoperes
Tiagoperes suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@Tiagoperes Tiagoperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transforming a number to a string to then convert it to an Int or Double is really bad. Please, don't do string parsing if you don't really need to.

@arthurbleilzup
fix convertions
6dfcbc4 
Signed-off-by: Arthur Bleil <[email protected]>
Tiagoperes
Tiagoperes suggested changes Nov 1, 2022
View reviewed changes
src/operation/convert.ts Outdated Show resolved Hide resolved
arthurbleilzup and others added 10 commits November 1, 2022 10:01
@arthurbleilzup @Tiagoperes
Update src/operation/convert.ts
f06de12 
Co-authored-by: Tiago Peres França <[email protected]>
@arthurbleilzup
update for performance
8f36b9e 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix check-types
9f5c25c 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix check-types 2
f875912 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix check-types 3
6931ed6 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix check-types 4
0db14c4 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix check-types 5
588ab33 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
base commit
08fc575 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix horusec
fb99788 
Signed-off-by: Arthur Bleil <[email protected]>
@arthurbleilzup
fix horusec 2
bc5bad0 
Signed-off-by: Arthur Bleil <[email protected]>
@github-actions
Copy link
Contributor

➿ Code coverage

Filename Statements Branches Functions Lines
src/logger/index.ts 79.17% 75% 90% 81.82%
src/beagle-view/render/expression.ts 98.97% 96.49% 100% 100%
src/utils/automaton.ts 100% 100% 100% 100%
src/utils/expression.ts 38.46% 0% 0% 38.46%
src/beagle-view/render/context.ts 100% 100% 100% 100%
src/error/BeagleParseError.ts 100% 100% 100% 100%
src/error/BeagleError.ts 100% 100% 100% 100%
src/utils/context.ts 100% 100% 100% 100%
src/error/BeagleNotFoundError.ts 100% 100% 100% 100%
src/operation/index.ts 100% 100% 100% 100%
src/operation/array.ts 100% 100% 100% 100%
src/operation/convert.ts 100% 100% 100% 100%
src/operation/logic.ts 100% 100% 100% 100%
src/operation/number.ts 100% 100% 100% 100%
src/operation/other.ts 100% 100% 100% 100%
src/operation/string.ts 100% 100% 100% 100%
src/beagle-view/local-contexts/manager.ts 100% 100% 100% 100%
src/beagle-view/local-contexts/context.ts 51.52% 30.77% 44.44% 57.14%
src/action/set-context.ts 91.89% 75% 100% 94.12%
src/beagle-tree/index.ts 100% 100% 100% 100%
src/beagle-tree/iteration.ts 97.22% 90% 87.5% 100%
src/beagle-tree/manipulation.ts 90.91% 60% 100% 100%
src/beagle-tree/reading.ts 97.62% 94.12% 100% 100%
src/action/index.ts 100% 100% 100% 100%
src/action/add-children.ts 100% 85.71% 100% 100%
src/action/send-request.ts 100% 91.67% 100% 100%
src/error/BeagleNetworkError.ts 100% 83.33% 100% 100%
src/action/alert.ts 100% 100% 100% 100%
src/action/confirm.ts 100% 100% 100% 100%
src/action/submit-form.ts 25% 0% 0% 25%
src/action/condition.ts 100% 100% 100% 100%
src/action/navigation/index.ts 96.15% 57.14% 100% 100%
src/utils/url.ts 100% 100% 100% 100%
src/utils/string.ts 100% 100% 100% 100%
src/utils/object.ts 100% 60% 100% 100%
src/beagle-view/render/action.ts 100% 100% 100% 100%
src/service/beagle-service/index.ts 100% 100% 100% 100%
src/service/beagle-service/configuration.ts 100% 100% 100% 100%
src/metadata/parser.ts 94.44% 75% 100% 100%
src/service/beagle-service/services.ts 100% 100% 100% 100%
src/service/network/url-builder/index.ts 100% 100% 100% 100%
src/service/network/view-client/index.ts 88% 76.92% 100% 86.96%
src/service/network/view-client/utils.ts 92.31% 83.33% 100% 100%
src/service/global-context/index.ts 100% 100% 100% 100%
src/service/view-content-manager/index.ts 90.91% 100% 81.82% 90.48%
src/service/analytics/index.ts 100% 81.82% 100% 100%
src/service/analytics/actions.ts 100% 90% 100% 100%
src/utils/html.ts 85% 60% 100% 100%
src/beagle-view/index.ts 96.97% 100% 88.89% 96.67%
src/beagle-view/render/index.ts 92.71% 67.31% 100% 95.35%
src/beagle-view/render/template-manager/index.ts 100% 100% 100% 100%
src/beagle-view/render/component.ts 100% 100% 100% 100%
src/beagle-view/render/styling.ts 94.89% 85.71% 100% 99.17%
src/beagle-view/render/type-checker.ts 100% 100% 100% 100%
src/beagle-navigator/default-web-navigator.ts 94.95% 82.14% 100% 100%
src/beagle-navigator/default-web-controller.ts 100% 100% 100% 100%
src/beagle-navigator/double-stack.ts 100% 100% 100% 100%
src/metadata/decorator.ts 100% 100% 100% 100%
src/index.ts 100% 100% 100% 100%

@Tiagoperes Tiagoperes merged commit ee0e51c into main Nov 11, 2022
@Tiagoperes Tiagoperes deleted the feat/convertion-operations branch November 11, 2022 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tiagoperes Tiagoperes Tiagoperes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurbleilzup @Tiagoperes