This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Treats LocalView route types when PopToVIew #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcustodiozup
requested review from
carolinegoncalveszup,
jamessonpenhazup,
leonardosantiagozup,
rafamsilva,
raphaelspimenta,
tarcisiogc,
tayronemachadozup and
Tiagoperes
as code owners
Tiagoperes
suggested changes
Oct 6, 2020
There was a problem hiding this comment.
No core, é sempre necessário fazer testes quando se implementa uma feature ou um fix.
No caso do fix, se existia algo quebrado que não era detectado por um teste é pq tínhamos uma falha e um ou mais testes novos, que detectam essa falha, devem ser criados.
Sugestão:
- should pop to a local view
- should pop to first view matching the route: teste aquele caso em que eu falei que a sua regra não funcionaria, se tem url e screenIds iguais em diferentes rotas.
Tiagoperes
reviewed
Oct 6, 2020
…p-to-view-navigation
…p-to-view-navigation
Tiagoperes
suggested changes
Oct 7, 2020
There was a problem hiding this comment.
Hector, lendo os novos testes, percebi um outro bug no popToView. Como está relacionado ao que vc fez, acho interessante já corrigir.
Além disso, na minha opinião, faltou um teste para verificar melhor que tudo funciona.
Explico melhor nos comentários quais os problemas e o que deve ser feito para corrigi-los.
Tiagoperes
approved these changes
Oct 8, 2020
carolinegoncalveszup
approved these changes
Oct 9, 2020
|
➿ Code coverage
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #258
- What I did
Fixed problem where pop to view navigation would not work if the route passed was an identifier instead of URL
- How I did it
Checked the type of the route and verified any existing Identifiers that would match
- How to verify it
Run the branch and try to use navigation action pop to view
- Description for the changelog
Fixes popToView action with LocalView