This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Fix/ts3.1.1 compatibility #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiagoperes
requested review from
carolinegoncalveszup,
hectorcustodiozup,
jamessonpenhazup,
leonardosantiagozup,
rafamsilva,
raphaelspimenta,
tarcisiogc and
tayronemachadozup
as code owners
hectorcustodiozup
approved these changes
Oct 6, 2020
carolinegoncalveszup
approved these changes
Oct 6, 2020
|
➿ Code coverage
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Addresses #262. This is not a final fix, since we can easily introduce new incompatible code without ever realizing it. We still must find a way to guarantee the generated code to be compatible with older versions of Typescript (>= 3.1.1).
The generated code is now compatible and will work with Angular 7 and above (TS 3.1.1 and above). The problems were the following:
Omitinstead of using the one we defined ourselves. Old TS versions don't haveOmit.Iteratorwhen our targeted version is ES5, which doesn't support Iterators.- How I did it
types.tsOmitby theOmitintypes.tsIteratorfrom the ES6 definition to the filetypes.tsIteratorby theIteratorintypes.ts- How to verify it
Run it an angular 7 environment
- Description for the changelog