Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

replacing beagleView.fetch in the LazyComponent #195

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

Tiagoperes
Copy link
Contributor

- What I did
Depends on: ZupIT/beagle-web-core#251

The Pull request makes the following changes that needs to be addressed in Beagle Angular:

  • beagleView.fetch has been deprecated.
  • LoadParams should not be used anymore to create a BeagleView. We should use the new parameters: route, networkOptions and controllerId.

The previous parameters for the BeagleRemoteView will keep working, but have been deprecated and warning have been added.

- How I did it

  • Replaced the beagleView.fetch in the component LazyComponent for a more crude implementation that doesn't rely in the method that has been deprecated.
  • Altered the BeagleRemoteView component to accept the new parameters.

- How to verify it

  • POC beagle-forms
  • Playground

- Description for the changelog

  • Deprecated LoadParams in the BeagleView. route, networkOptions and controllerId should be used instead.

@github-actions
Copy link

Code coverage

Filename Statements Branches Functions Lines
src/codegen/utils/formatting.ts 57.14% 100% 25% 66.67%
src/errors.ts 0% 100% 0% 0%
src/cli/utils/styledLogger.ts 0% 0% 0% 0%
src/decorator.ts 0% 100% 0% 0%
src/cli/utils/object.ts 0% 0% 0% 0%
src/cli/utils/userInput.ts 0% 0% 0% 0%
src/cli/utils/filesystem.ts 0% 0% 0% 0%
src/cli/utils/packages.ts 0% 0% 0% 0%
src/cli/utils/git.ts 0% 0% 0% 0%
src/cli/errors.ts 0% 0% 0% 0%
src/cli/operations/view-engine/config.ts 0% 0% 0% 0%
src/cli/operations/view-engine/index.ts 0% 0% 0% 0%
src/cli/operations/init/questions.ts 0% 0% 0% 0%
src/cli/operations/init/ivy.ts 0% 0% 0% 0%
src/cli/operations/view-engine/process.ts 0% 0% 0% 0%
src/cli/operations/init/view-engine.ts 0% 0% 0% 0%
src/cli/operations/init/configuration.ts 0% 100% 0% 0%
src/cli/operations/init/boilerplate.ts 0% 0% 0% 0%
src/cli/operations/init/index.ts 0% 0% 0% 0%
src/cli/operations/help.ts 0% 0% 0% 0%
src/cli/operations/index.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/module.ts 0% 0% 0% 0%
src/codegen/compiled/beagle.module/imports.ts 0% 0% 0% 0%
src/cli/index.ts 0% 0% 0% 0%
src/codegen/compiled/beagle.module/template.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/commentary.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/index.ts 0% 100% 0% 0%
src/codegen/utils/template-builder.ts 0% 0% 0% 0%
src/codegen/utils/metadata.ts 0% 0% 0% 0%
src/codegen/utils/handle-user-default-components.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/component.ts 0% 0% 0% 0%
src/codegen/errors.ts 0% 100% 0% 0%
src/codegen/boilerplate/beagle.module.ts 0% 0% 0% 0%
src/components/beagle-error/beagle-error.component.ts 0% 100% 100% 0%
src/codegen/boilerplate/beagle-components.module.ts 0% 0% 0% 0%
src/components/beagle-tab-view/beagle-tab-view.lifecycles.ts 0% 0% 0% 0%
src/components/beagle-tab-view/beagle-tab-view.component.ts 0% 0% 0% 0%
src/components/beagle-touchable/beagle-touchable.component.ts 0% 0% 0% 0%
src/components/beagle-future-list-view/beagle-list-view.component.ts 0% 0% 0% 0%
src/components/beagle-future-list-view/beagle-list-view.on-init.ts 0% 0% 0% 0%
src/components/beagle-future-list-view/beagle-list-view.scroll.ts 0% 0% 0% 0%
src/components/beagle-tab-bar/beagle-tab-bar.component.ts 0% 0% 0% 0%
src/components/beagle-page-indicator/beagle-page-indicator.component.ts 0% 0% 0% 0%
src/components/module.ts 0% 100% 100% 0%
src/components/beagle-text-area/beagle-text-area.component.ts 0% 0% 0% 0%
src/components/beagle-page-view/beagle-page-view.component.ts 0% 0% 0% 0%
src/components/beagle-simple-form/beagle-simple-form.component.ts 0% 0% 0% 0%
src/components/beagle-tab-item/beagle-tab-item.component.ts 0% 0% 0% 0%
src/components/beagle-modal/beagle-modal.component.ts 0% 0% 0% 0%
src/components/beagle-container/beagle-container.component.ts 0% 0% 0% 0%
src/components/beagle-loading/beagle-loading.component.ts 0% 100% 100% 0%
src/components/schemas/button.ts 0% 100% 100% 0%
src/components/beagle-list-view/beagle-list-view.component.ts 0% 100% 100% 0%
src/components/beagle-input/beagle-input.component.ts 0% 0% 0% 0%
src/components/beagle-markdown/beagle-markdown.component.ts 0% 0% 0% 0%
src/components/services/tabs.service.ts 0% 100% 0% 0%
src/components/beagle-button/beagle-button.component.ts 0% 0% 0% 0%
src/components/beagle-text/beagle-text.component.ts 0% 0% 0% 0%
src/components/beagle-webview/beagle-webview.component.ts 0% 0% 0% 0%
src/components/beagle-image/beagle-image.component.ts 0% 0% 0% 0%
src/components/index.ts 0% 100% 100% 0%
src/components/beagle-lazy/beagle-lazy.component.ts 0% 100% 0% 0%
src/constants.ts 0% 100% 100% 0%
src/runtime/utils/beagle-map-keys-config.ts 0% 100% 0% 0%
src/runtime/utils/promise.ts 0% 100% 0% 0%
src/runtime/AbstractBeagleRemoteView.ts 0% 0% 0% 0%
src/runtime/errors.ts 0% 100% 0% 0%
src/runtime/view-content-manager/module.ts 0% 100% 100% 0%
src/runtime/AngularHttpClientConfig.service.ts 0% 0% 0% 0%
src/runtime/BeagleComponent.ts 0% 100% 100% 0%
src/runtime/view-content-manager/directive.ts 0% 0% 0% 0%
src/runtime/BeagleProvider.service.ts 0% 0% 0% 0%
src/index.ts 0% 100% 100% 0%

@leonardosantiagozup leonardosantiagozup merged commit fa52bdc into master Sep 21, 2020
@leonardosantiagozup leonardosantiagozup deleted the feature/navigation-controllers branch September 21, 2020 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants