Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

feat: [DRAFT] Eq not working (WIP) #106

Closed
wants to merge 15 commits into from
Closed

feat: [DRAFT] Eq not working (WIP) #106

wants to merge 15 commits into from

Conversation

TomerPacific
Copy link

Related Issues

Related to #1823

Description and Example

To support handling different types of data types, a new interface was created, called ComparisonOperationHandler.
There we handle all the cases for comparison operators.

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.
  • I have made the documentation changes or I created an issue explaining how to document this change on Docs issues. Please link the issue here:

@hernandazevedozup
Copy link
Contributor

hernandazevedozup commented Oct 24, 2022

I think the overall solution is going to the right way, maybe there is a way to avoid duplication for the method private fun handleOperation. Are you planning to contribute with the other items( 2 and 3) of the issue?

  1. Make the following operations agnostic to the type of the data: sum, subtract, multiply, divide
  2. Create operations to convert types:

@hernandazevedozup hernandazevedozup changed the title [DRAFT] Eq not working (WIP) feat: [DRAFT] Eq not working (WIP) Oct 24, 2022
@TomerPacific
Copy link
Author

@hernandazevedozup, as this is a draft PR, I wanted to show you the direction of the code.
I didn't continue to the number 2 item since I didn't want to write a whole lot of code that will get reverted if what I am doing was wrong.

I plan on continuing to item number 2 and 3 and make some refactoring to avoid duplication.

@Tiagoperes
Copy link
Contributor

Hi @TomerPacific. We really appreciate your help, but we need this feature asap. For this reason, @hernandazevedozup will pick this up from where you left it.

@TomerPacific TomerPacific closed this by deleting the head repository Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants