This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent cases and convert types
…f arguments with comparison operators
…rOperation in EqOperation
I think the overall solution is going to the right way, maybe there is a way to avoid duplication for the method private fun handleOperation. Are you planning to contribute with the other items( 2 and 3) of the issue?
|
hernandazevedozup
changed the title
[DRAFT] Eq not working (WIP)
feat: [DRAFT] Eq not working (WIP)
Oct 24, 2022
@hernandazevedozup, as this is a draft PR, I wanted to show you the direction of the code. I plan on continuing to item number 2 and 3 and make some refactoring to avoid duplication. |
Hi @TomerPacific. We really appreciate your help, but we need this feature asap. For this reason, @hernandazevedozup will pick this up from where you left it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to #1823
Description and Example
To support handling different types of data types, a new interface was created, called ComparisonOperationHandler.
There we handle all the cases for comparison operators.
Checklist
Please, check if these important points are met using
[x]
: