Fix watchdog timeout #371
Merged
Fix watchdog timeout #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing issue #350 When implementing a dynamic watchdog setup, a fixed alarm number was passed instead of the dynamic one. This fixes the issue for the RP2040 targets. The Earl E Philhower PlatoformIO framework doesn't use mbed so error reporting hasn't been fully implemented yet.
With the arduino pico framework, the proper stack pointer is the MSP. Using that fixes a hard fault. The original RP2040 code uses still uses the PSP. Selection is done via C macro against __MBED__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the watchdog time out for the ZuluSCSI Pico DaynaPort target and any builds using Earl E Philhower's Pico PlatoformIO framework