Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messaging for both the rev 2023b and 2023c #304

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update messaging for both the rev 2023b and 2023c #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/ZuluSCSI_platform_RP2040/ZuluSCSI_platform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ static pin_setup_state_t read_setup_ack_pin()
* The 74LVT245 hold current is keeping the GPIO_ACK state too strongly.
* Detect this condition by toggling the pin up and down and seeing if it sticks.
*
* Revision 2023b of the Pico hardware has issues reading TERM and DEBUG DIP switch
* Revision 2023b and 2023c of the Pico boards have issues reading TERM and DEBUG DIP switch
* settings. GPIO_ACK is externally pulled down to ground for later revisions.
* If the state is detected as undetermined then the board is the 2023b revision.
* If the state is detected as undetermined then the board is the 2023b or 2023c revision.
*/

// Strong output high, then pulldown
Expand Down Expand Up @@ -171,7 +171,7 @@ void platform_init()
bool dbglog = false;
bool termination = false;
# ifdef ZULUSCSI_PICO
// Initiator dip setting works on both rev 2023b and newer rev Pico boards
// Initiator dip setting works on all rev 2023b, 2023c, and newer rev Pico boards
g_scsi_initiator = !gpio_get(DIP_INITIATOR);

working_dip = SETUP_UNDETERMINED != read_setup_ack_pin();
Expand Down Expand Up @@ -221,7 +221,7 @@ void platform_init()
{
logmsg("SCSI termination is determined by the DIP switch labeled \"TERM\"");
logmsg("Debug logging can only be enabled via INI file \"DEBUG=1\" under [SCSI] in zuluscsi.ini");
logmsg("-- DEBUG DIP switch setting is ignored on ZuluSCSI Pico FS Rev. 2023b boards");
logmsg("-- DEBUG DIP switch setting is ignored on ZuluSCSI Pico FS Rev. 2023b and 2023c boards");
g_log_debug = false;
}
#else
Expand Down