Fixes for Apple vendor modepage sending #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears there was an extra 0x00 at the end.
Apparently there was a mistake between || and && that caused Apple vendor page to be sent even when Apple quirks were disabled and when it wouldn't fit the buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in ModeSense implementation that caused Apple vendor modepage 0x30 to be sent even when quirks were set to 0. This bug remains in SCSI2SDv6, but was earlier fixed in SCSI2SDv5. In ZuluSCSI code, the bug was masked by an extra 0x00 at the end of the modepage constant, which caused the length check to be negative in most cases.
The changes made here did not improve behavior in #272, but I think this is more correct and should work the same on most systems.
Requires testing on a Mac that cares about 0x30 modepage for CD-ROM before merging. Not sure which systems do this, Mac LC III does not seem to care.