Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Release ZuluSCSI firmware v2023.11.22 breaks implicit device typing #340

Closed
ZigZagJoe opened this issue Nov 25, 2023 · 4 comments
Closed

Comments

@ZigZagJoe
Copy link
Collaborator

ZigZagJoe commented Nov 25, 2023

Issue:

All devices are getting initialized with info for fixed drives. Implicit device types - such as a file named NE0.bin is a network device - are only determined later. The drive info strings need to be updated with any drive type info found while scanning for images.

I specifically had this issue with network devices, seems likely the same applies to other image types (ie. CDs).

Replication:

  • Create NE0.bin
  • Boot system.
  • Find SCSI ID #0 info strings reported with the contents of DRIVEINFO_FIXED
  • Dayna functionality does not work due to incorrect device info

This is only an issue with the 11-22 release - 10-31 is OK. Suspect is related to 7f4104c.

Screenshot before I added quirks=1 to the zuluscsi.ini
PXL_20231125_020530847

the zululog is from a build i was using to diagnose. Only change is to make setDefaultDriveInfo report what settings it is initializing with. Issue occurs with the official builds.
zululog.txt

zuluscsi.ini.txt

2023-11-24 21_07_53-TINYSCSI (G_)

@aperezbios
Copy link
Collaborator

@ZigZagJoe thanks, as of last night I un-flagged the v2023.11.22 release as latest, and users should continue to use the previous v2023.10.31 until then. We expeect to have the problem resolved no later than Monday morning.

morio added a commit that referenced this issue Nov 27, 2023
This is a fix for issue: #340

The device type from a filename (e.g. NE5.img) and its implicit scsi
vendor and model stings weren't being set after moving a lot off the
SCSI settings code to ZuluSCSI_settings.cpp.

This fix addresses the issue. Although more effort, it might make sense
to move more of the SCSI device setup to ZuluSCSI_settings.cpp like
image discovery. The current fix just plugs into ZuluSCSI.cpp
`findHDDImages()`.
@morio
Copy link
Collaborator

morio commented Nov 28, 2023

Thanks for the find @ZigZagJoe
Here is an attempt at a fix
https://github.com/ZuluSCSI/ZuluSCSI-firmware/actions/runs/7012142248
Could you see if it resolves your issue?

@ZigZagJoe
Copy link
Collaborator Author

Thanks for the find @ZigZagJoe Here is an attempt at a fix https://github.com/ZuluSCSI/ZuluSCSI-firmware/actions/runs/7012142248 Could you see if it resolves your issue?

Yes, looks good. I just gave it a whirl and I see the expected device info strings for both CD-ROM and network device types. CD-Rom mounts, Dayna driver recognizes the network device and network functionality works too.

aperezbios added a commit that referenced this issue Nov 28, 2023
Restore implicit device settings. This is a fix for issue: #340
@aperezbios
Copy link
Collaborator

This has been fixed with the v2023.11.27 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants