Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/fix signature indexing #71

Closed
wants to merge 1 commit into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Sep 24, 2024

An attempt to close #70 . Fixes the issue where incorrect spend authorization signatures are returned when the number of spend randomness parameters exceeds the number of spend descriptions. This fix essentially uses a new separate variable (instead of index difference arithmetic) to track which spend authorization signature we are returning next.

@murisi murisi changed the base branch from main to fixes September 24, 2024 19:20
@chcmedeiros chcmedeiros deleted the branch Zondax:fixes October 8, 2024 15:02
@chcmedeiros chcmedeiros closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect spend authorization signatures returned by hardware wallet
2 participants