feat: use to ledger rust sdk crate

.github/workflows/main.yml

@@ -45,6 +45,12 @@ jobs:
         run: make zemu_install
       - name: Run tests
         run: make zemu_test
+      - name: Upload Snapshots (only failure)
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@v3
+        with:
+          name: snapshots-tmp
+          path: tests_zemu/snapshots-tmp/
 
   build_package_nanosp:
     needs: [configure, build_and_test]

app/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ledger-ironfish-dkg"
-version = "0.0.0" # The version is being taken from Makefile.version file
+version = "0.0.0"            # The version is being taken from Makefile.version file
 edition = "2021"
 
 [[bin]]
@@ -9,8 +9,8 @@ test = false
 path = "bin-app/app.rs"
 
 [dependencies]
-ledger_device_sdk = { git = "https://github.com/Zondax/ledger-device-rust-sdk", rev = "9408c1ffc278a363e1903b4cc0b765a31c4eeace", optional = true }
-# ledger_device_sdk = { version="1.14.0" , optional = true}
+# ledger_device_sdk = { git = "https://github.com/Zondax/ledger-device-rust-sdk", rev = "923e5cf53d09e0e81c64eecc92c26800fad4bf45", optional = true }
+ledger_device_sdk = { version = "1.17.1", optional = true }
 # ledger_device_sdk = { path="../../ledger-device-rust-sdk/ledger_device_sdk" , optional = true}
 include_gif = "1.2.0"
 serde = { version = "1.0.192", default_features = false, features = ["derive"] }
@@ -44,7 +44,9 @@ lazy_static = { version = "1.5.0", default-features = false, features = [
 spin = { version = "0.9.8", default-features = false, features = [
     "spin_mutex",
 ], optional = true }
-lexical-core = { version = "1.0.1", default-features = false, features = ["write-integers"] }
+lexical-core = { version = "1.0.1", default-features = false, features = [
+    "write-integers",
+] }
 
 [dev-dependencies]
 lazy_static = { version = "1.5.0" }
@@ -70,6 +72,8 @@ lto = true
 [features]
 default = ["ledger"]
 ledger = ["ledger_device_sdk", "spin", "lazy_static/spin_no_std"]
+# This will require to use zondax ledger device sdk, where zlog is added.
+ledger-debug = ["ledger_device_sdk", "spin", "lazy_static/spin_no_std"]
 
 [package.metadata.ledger]
 curve = ["ed25519"]

app/src/app_ui/run_action.rs

@@ -87,7 +87,7 @@ pub fn ui_review_transaction<'a>(
             .map(|(name, value)| Field { name, value })
             .collect();
 
-        let mut review = NbglReview::new()
+        let review = NbglReview::new()
             .tx_type(TransactionType::Transaction)
             .titles("Review", "Transaction", "Approve Transaction?")
             .glyph(&FERRIS);
@@ -391,7 +391,7 @@ pub fn ui_review<'a>(
         #[cfg(target_os = "flex")]
         const ICON: NbglGlyph = NbglGlyph::from_include(include_gif!("flex_icon.gif", NBGL));
 
-        let mut review = NbglReview::new()
+        let review = NbglReview::new()
             .tx_type(TransactionType::Operation)
             .light()
             .titles(title, _subtitle, _finish_title)

app/src/bolos.rs

@@ -1,4 +1,4 @@
-#[cfg(feature = "ledger")]
+#[cfg(feature = "ledger-debug")]
 extern "C" {
     fn check_app_canary();
     fn zemu_log_stack(ctx: *const u8);
@@ -7,14 +7,14 @@ extern "C" {
 }
 
 pub fn app_canary() {
-    #[cfg(feature = "ledger")]
+    #[cfg(feature = "ledger-debug")]
     unsafe {
         check_app_canary()
     }
 }
 
 pub fn zlog(_buf: &str) {
-    #[cfg(feature = "ledger")]
+    #[cfg(feature = "ledger-debug")]
     unsafe {
         zemu_log(_buf.as_bytes().as_ptr())
     }
@@ -23,17 +23,17 @@ pub fn zlog(_buf: &str) {
 }
 
 pub fn zlog_stack(_buf: &str) {
-    #[cfg(feature = "ledger")]
+    #[cfg(feature = "ledger-debug")]
     unsafe {
         zemu_log_stack(_buf.as_bytes().as_ptr())
     }
     #[cfg(test)]
     std::println!("{_buf}")
 }
 
-pub fn zlog_num(buf: &str, num: u32) {
-    #[cfg(feature = "ledger")]
+pub fn zlog_num(_buf: &str, _num: u32) {
+    #[cfg(feature = "ledger-debug")]
     unsafe {
-        zemu_log_num(buf.as_bytes().as_ptr(), num)
+        zemu_log_num(_buf.as_bytes().as_ptr(), _num)
     }
 }