-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native event metadata parsing #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Really amazing!
@ziscky can we update the PR description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix tests first! Besides, please check int64 does not fit on JSON format. Those should be strings too :/ Check the max JSON number! Made me think we could represent numbers as strings directly. Not sure what it is easier to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if the value can be negative, as the ipld kind is Int, and we later compare to Uint32... My only doubt here!
Updated to check both bounds |
https://app.clickup.com/t/8694tyanq
This PR addresses the issue of misrepresenting event values containing CIDs and BigInts in the parsed metadata.
{}
.base64
encoding of the raw bytes.Tests have also been updated accordingly.
References:
🔗 zboto Link