Multisig parser #196
Merged
Multisig parser #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
requested changes
Jun 11, 2024
emmanuelm41
requested changes
Jun 11, 2024
emmanuelm41
reviewed
Jun 13, 2024
raynaudoe
reviewed
Jun 14, 2024
emmanuelm41
approved these changes
Jun 14, 2024
| @@ -180,12 +180,12 @@ func (h *Helper) FilterTxsByActorType(ctx context.Context, txs []*types.Transact | |||
| addrTo, err := address.NewFromString(tx.TxTo) | |||
| if err != nil { | |||
| h.logger.Sugar().Errorf("could not parse address. Err: %s", err) | |||
| return nil, err | |||
There was a problem hiding this comment.
I don't really like this, as if something fails, we loose the tx at all, and never know. I guess this is the general approach on the fil parser, so I am ok now. But in the future we need a way to track these errors, as we won't never be able to fix them otherwise.
There was a problem hiding this comment.
agree, we need to include some metrics here
| @@ -87,7 +87,7 @@ func (eg *eventGenerator) GenerateMultisigEvents(ctx context.Context, transactio | |||
| addrTo, err := address.NewFromString(tx.TxTo) | |||
| if err != nil { | |||
| eg.logger.Sugar().Errorf("could not parse address. Err: %s", err) | |||
| return nil, err | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 zboto Link