Feat/arbitrary messages #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raynaudoe
reviewed
Oct 10, 2023
| ## Specification | ||
|
|
||
| Off-chain signed messages should resemble Cosmos SDK messages but **must not** constitute a valid on-chain transaction. | ||
| `chain-id`, `account_number`, and `sequence` must all be assigned invalid values. |
There was a problem hiding this comment.
Nothing serious, just a thing to keep in mind, I don't know the details about how the ledger app works but the app shouldn't reject the tx if any of those fields contains "Invalid" values.
There was a problem hiding this comment.
yeah, this has been tested and its not a problem.
| // Signer is the sdk.AccAddress of the message signer | ||
| string signer = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; | ||
| // Data represents the raw bytes of the content that is signed (text, json, etc) | ||
| bytes data = 3 [(gogoproto.jsontag) = "data"]; |
There was a problem hiding this comment.
is there a size limit for data ? or maybe signing the digest of a file ?
There was a problem hiding this comment.
good question, I guess the only limit here would come from HSM devices. Maybe its a good open question to add here
Co-authored-by: Ezequiel Raynaudo <[email protected]>
bizk
reviewed
Oct 10, 2023
bizk
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.