Update to Zewo 0.13 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changing `ErrorProtocol` to `Error` - importing `Core` - `StringLiteralConvertible` -> `ExpressibleByStringLiteral` - string `split` -> `components`
| } | ||
|
|
||
| public protocol ConnectionProtocol: class { | ||
| associatedtype InternalStatus | ||
| associatedtype Result: ResultProtocol | ||
| associatedtype Error: ErrorProtocol, CustomStringConvertible | ||
| associatedtype ErrorAndStringConvertible: Error, CustomStringConvertible |
There was a problem hiding this comment.
Any reason you named this ErrorAndStringConvertible? It reads a lot nicer as Error even if it is CustomStringConvertible
There was a problem hiding this comment.
I assume it's because Error is a reserved name by swift now. I'll change it to ConnectionError
- Fix .gitignore, .swift-version, .travis.yml, LICENSE - Remove license headers from files - Remove trailing whitespace from all files - ErrorAndStringConvertible -> ConnectionError
|
I rebased on master and fixed a few things. Your part looks good! Once CI passes I'll merge 👍 |
|
Excellent! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to update package to use Zewo 0.13, swift 3.0