Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance user model #24

Merged
merged 23 commits into from
Aug 21, 2020
Merged

Enhance user model #24

merged 23 commits into from
Aug 21, 2020

Conversation

mcbloch
Copy link
Member

@mcbloch mcbloch commented Aug 6, 2020

No description provided.

@redfast00 redfast00 mentioned this pull request Aug 7, 2020
Merged
@ajuvercr
Copy link
Contributor

ajuvercr commented Aug 8, 2020

Looks pretty good

redfast00
redfast00 requested changes Aug 9, 2020
View reviewed changes
migrations/2019-10-30-155718_schema/up.sql Outdated Show resolved Hide resolved
migrations/2019-10-30-155718_schema/up.sql Show resolved Hide resolved
templates/users/show.html Outdated Show resolved Hide resolved
templates/users/show.html Outdated Show resolved Hide resolved
src/models/user.rs Outdated Show resolved Hide resolved
@mcbloch mcbloch marked this pull request as ready for review August 11, 2020 17:58
rien
rien reviewed Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@rien rien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Please also run cargo fmt. I think your editor made some changes to the spacing, making it difficult to review those sections.

migrations/2019-10-30-155718_schema/up.sql Outdated Show resolved Hide resolved
migrations/2019-10-30-155718_schema/up.sql Outdated Show resolved Hide resolved
migrations/2019-10-30-155718_schema/up.sql Outdated Show resolved Hide resolved
templates/users/index.html Outdated Show resolved Hide resolved
templates/users/index.html Outdated Show resolved Hide resolved
templates/users/show.html Outdated Show resolved Hide resolved
templates/users/show.html Outdated Show resolved Hide resolved
rien
rien reviewed Aug 13, 2020
View reviewed changes
src/controllers/pages_controller.rs Outdated Show resolved Hide resolved
src/models/user.rs Show resolved Hide resolved
templates/users/show.html Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
mcbloch and others added 20 commits August 21, 2020 19:41
@mcbloch
Add other fields to user struct and migration
d5eb4cf
@mcbloch
Extend user change and creation forms and models
e23cb75
@mcbloch
last_accessed_at -> last_seen
ea30823
@mcbloch
Fix date types
75f405a
@mcbloch
Fix dates in scheme
30a4092
@mcbloch
Make email unique for user
1fead53
@mcbloch
Add column for upcoming password change
f19187d
@mcbloch
Update newUser structs in tests
1a4a094
@mcbloch
Fix more user forms in the tests
4d7b598
@mcbloch
convert put to urlencoded form instead of formdata
6629de8
@mcbloch @rien
Make ssh uppercase in html
9e45ba7 
Co-authored-by: Rien <[email protected]>
@mcbloch @rien
Change show name of the last_seen field.
69ec528 
Co-authored-by: Rien <[email protected]>
@mcbloch
Add created at field to client
9da527e
@mcbloch
Add created_at struct field to client, remove 'Found' debug string fr…
753a385 
…om html
@mcbloch @rien
firstname -> first_name
5915438 
Co-authored-by: Rien <[email protected]>
@mcbloch
Run cargo fmt on the project.
c1206b5
@mcbloch
Change firstname -> first_name everywhere
ea09e67
@mcbloch
Push serde dep back up
3a0630a
@mcbloch
Change last_seen to last_login
13ea55f
@mcbloch
Run rustfmt
953b1b3
@rien rien merged commit f1be97e into master Aug 21, 2020
@mcbloch mcbloch deleted the enhance-user-model branch August 21, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redfast00 redfast00 redfast00 requested changes

@wschella wschella wschella left review comments

@iasoon iasoon iasoon left review comments

@rien rien rien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcbloch @ajuvercr @rien @iasoon @wschella @redfast00