Sord 564 update button #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementdejoie
force-pushed
the
SORD-564-Update-button
branch
from
124087e to
a0e236e
Compare
| marginHorizontal: size === 's' ? 16 : 22, | ||
| fontSize: | ||
| size === 's' | ||
| ? theme.sw.typography.button.n3!.fontSize |
There was a problem hiding this comment.
pourquoi le point d'exclamation a 'n3', il est potentiellement null ?
There was a problem hiding this comment.
Pour typer les typographies (button, headline, body et label) on utilise un même type et il y a des typographies qui s'arrête à n2 :-/. Mais pas button.
Comment on lines
+57
to
+58
| ? (theme.sw.typography.button.n3!.fontWeight as never) | ||
| : (theme.sw.typography.button.n1.fontWeight as never), |
There was a problem hiding this comment.
Oui, notre type ne match pas parfaitement celui attendu, mais fonctionne très bien... Il faudrait peut-être revoir les types retournés par la librairie de token (https://github.com/ZeroGachis/smartway-design-token)
valentinmagrez
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.