Task/sdet 223 appliquer les styles derreur quand il faut #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienCasta
force-pushed
the
task/sdet-223-appliquer-les-styles-derreur-quand-il-faut
branch
from
c409a49 to
8bfb856
Compare
|
|
||
| type DateSelectorProps = WithTestID<{ | ||
| prefilled: Date; | ||
| errorMessage?: string; | ||
| onChange: (date: Date) => void; | ||
| onUpdatedDate: (date: Date) => boolean; |
There was a problem hiding this comment.
Modifier le retour en 'void'
clementdejoie
approved these changes
Jan 30, 2024
clementdejoie
force-pushed
the
task/sdet-223-appliquer-les-styles-derreur-quand-il-faut
branch
from
89b4c33 to
a54a7a0
Compare
AdrienCasta
force-pushed
the
task/sdet-223-appliquer-les-styles-derreur-quand-il-faut
branch
from
a54a7a0 to
b96766e
Compare
tuxtoby
reviewed
Jan 30, 2024
Comment on lines
105
to
111
| function getPlaceholderColorsStyle(theme: Theme, state: State) { | ||
| let textColor: string | undefined = theme.sw.colors.neutral[500]; | ||
| if (state === 'empty-focused') { | ||
| textColor = theme.sw.colors.primary.main; | ||
| } | ||
| return { | ||
| textColor, | ||
| }; |
There was a problem hiding this comment.
pourquoi renvoyer un objet alors que l'on veut renvoyer directement juste une couleur?
There was a problem hiding this comment.
J'ai voulu avoir le même type de retour que getTextInputStyle qui a la même utilité mais au niveau des styles du TextInput
tuxtoby
reviewed
Jan 30, 2024
Comment on lines
+120
to
+122
| textColor = theme.sw.colors.neutral[800]; | ||
| backgroundColor = theme.sw.colors.neutral[50]; | ||
| borderColor = theme.sw.colors.primary.main; | ||
| break; |
There was a problem hiding this comment.
ça change pa grand chose mais pourquoi ne pas faire:
return {
textColor : theme.sw.colors.neutral[800],
backgroundColor : theme.sw.colors.neutral[50],
borderColor : theme.sw.colors.primary.main
}
Ca évite le break à chaque fois, et le return à la fin?
AdrienCasta
force-pushed
the
task/sdet-223-appliquer-les-styles-derreur-quand-il-faut
branch
from
b96766e to
9604d03
Compare
AdrienCasta
deleted the
task/sdet-223-appliquer-les-styles-derreur-quand-il-faut
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enregistrement.2024-01-29.221206.mp4