Merge pull request #177 from ZeroGachis/task/fix-number-selector

🐛 SORD - rewrite props
ZeroGachis · Jan 30, 2024 · fdac469 · fdac469
2 parents 7a45602 + 12789d2
commit fdac469
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/components/modifyQuantity/ModifyQuantity.tsx b/src/components/modifyQuantity/ModifyQuantity.tsx
@@ -63,6 +63,13 @@ export const ModifyQuantity = ({
             justifyContent: 'center',
         },
     });
+
+    const onEndEditing = (value: string | undefined) => {
+        if (value) {
+            onValueChange(Number(value));
+        }
+    };
+
     return (
         <View style={styles.container}>
             <View style={styles.iconContainer}>
@@ -76,15 +83,10 @@ export const ModifyQuantity = ({
                 <Body style={styles.text}>{text}</Body>
             </View>
             <NumberSelector
-                minValue={minValue}
-                maxValue={maxValue}
-                onValueChange={onValueChange}
                 value={value}
-                validator={new NumberValidator(0, 10, false)}
+                validator={new NumberValidator(minValue, maxValue, false)}
                 initialValue={undefined}
-                onEndEditing={function (_: string | undefined): void {
-                    throw new Error('Function not implemented.');
-                }}
+                onEndEditing={onEndEditing}
             />
         </View>
     );

diff --git a/src/components/numberSelector/NumberSelector.tsx b/src/components/numberSelector/NumberSelector.tsx
@@ -9,7 +9,6 @@ export interface Props {
     validator: NumberValidator;
     initialValue: number | undefined;
     value: number | undefined;
-    onValueChange?: (value: number) => void;
     onEndEditing: (value: string | undefined) => void;
     style?: ViewStyle;
     minusIcon?: IconName;
@@ -25,6 +24,7 @@ export interface Props {
 export const RoundValue = (val: number): number => {
     return Math.round(val * 10) / 10;
 };
+
 export const ComputeCrementedValue = (
     value: number,
     step: number,