🎨 Add parsed value in error message

magicparse/type_converters.py

@@ -32,7 +32,7 @@ def apply(self, value: str) -> int:
         try:
             return int(value)
         except:
-            raise ValueError("value is not a valid integer")
+            raise ValueError(f"value '{value}' is not a valid integer")
 
     @staticmethod
     def key() -> str:
@@ -44,7 +44,7 @@ def apply(self, value: str) -> Decimal:
         try:
             return Decimal(value)
         except:
-            raise ValueError("value is not a valid decimal")
+            raise ValueError(f"value '{value}' is not a valid decimal")
 
     @staticmethod
     def key() -> str:
@@ -56,10 +56,10 @@ def apply(self, value: str) -> time:
         try:
             parsed = time.fromisoformat(value)
             if parsed.tzinfo is None:
-                raise ValueError("value is a naïve time reprensentation")
+                raise ValueError(f"value '{value}' is a naïve time reprensentation")
             return parsed
         except:
-            raise ValueError("value is not a valid time representation")
+            raise ValueError(f"value '{value}' is not a valid time representation")
 
     @staticmethod
     def key() -> str:
@@ -71,10 +71,10 @@ def apply(self, value: str) -> datetime:
         try:
             parsed = datetime.fromisoformat(value)
             if parsed.tzinfo is None:
-                raise ValueError("value is a naïve datetime reprensentation")
+                raise ValueError(f"value '{value}' is a naïve datetime reprensentation")
             return parsed
         except:
-            raise ValueError("value is not a valid datetime representation")
+            raise ValueError(f"value '{value}' is not a valid datetime representation")
 
     @staticmethod
     def key() -> str:

tests/test_fields.py

@@ -63,11 +63,11 @@ def test_csv_error_format():
     field = CsvField({"key": "ratio", "type": "decimal", "column-number": 1})
 
     with pytest.raises(ValueError) as error:
-        field.read_value(["hello"])
+        field.read_value("hello")
 
     assert field.error(error.value) == {
         "column-number": 1,
-        "error": "value is not a valid decimal",
+        "error": "value 'h' is not a valid decimal",
         "field-key": "ratio",
     }
 
@@ -78,11 +78,11 @@ def test_columnar_error_format():
     )
 
     with pytest.raises(ValueError) as error:
-        field.read_value(["hello"])
+        field.read_value("hello")
 
     assert field.error(error.value) == {
         "column-start": 0,
         "column-length": 5,
-        "error": "value is not a valid decimal",
+        "error": "value 'hello' is not a valid decimal",
         "field-key": "ratio",
     }

tests/test_schema.py

@@ -107,7 +107,7 @@ def test_error_display_row_number(self):
                 "row-number": 1,
                 "column-number": 1,
                 "field-key": "age",
-                "error": "value is not a valid integer",
+                "error": "value 'a' is not a valid integer",
             }
         ]
 
@@ -125,7 +125,7 @@ def test_errors_do_not_halt_parsing(self):
                 "row-number": 2,
                 "column-number": 1,
                 "field-key": "age",
-                "error": "value is not a valid integer",
+                "error": "value 'a' is not a valid integer",
             }
         ]
 
@@ -190,7 +190,7 @@ def test_error_display_row_number(self):
                 "column-start": 0,
                 "column-length": 1,
                 "field-key": "age",
-                "error": "value is not a valid integer",
+                "error": "value 'a' is not a valid integer",
             }
         ]
 
@@ -211,7 +211,7 @@ def test_errors_do_not_halt_parsing(self):
                 "column-start": 0,
                 "column-length": 1,
                 "field-key": "age",
-                "error": "value is not a valid integer",
+                "error": "value 'a' is not a valid integer",
             }
         ]
 

tests/test_type_converters.py

@@ -59,7 +59,7 @@ def test_apply(self):
     def test_apply_failed(self):
         type_converter = TypeConverter.build({"type": "int"})
 
-        with pytest.raises(ValueError, match="value is not a valid integer"):
+        with pytest.raises(ValueError, match="value 'abc' is not a valid integer"):
             type_converter.apply("abc")
 
 
@@ -71,7 +71,7 @@ def test_apply(self):
     def test_apply_failed(self):
         type_converter = TypeConverter.build({"type": "decimal"})
 
-        with pytest.raises(ValueError, match="value is not a valid decimal"):
+        with pytest.raises(ValueError, match="value 'abc' is not a valid decimal"):
             type_converter.apply("abc")