refactor(BarcodeInput): remove business logic from behavior #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sGeeK44
approved these changes
Nov 15, 2024
| if (input.Length == Ean13.CheckedLength && !Ean13.Check(input)) | ||
| return true; | ||
|
|
||
| return input.ToCharArray().Any(_ => !char.IsDigit(_)); |
There was a problem hiding this comment.
On veux pas garder la saisie unique de chiffre ?
There was a problem hiding this comment.
Si t'as raison, j'ai eu un doute parce que le code39 n'est pas limité aux chiffres par construction, mais j'ai re vérifié l'example mapping et on avait bien écrit que des chiffres alors gardons ce comportement.
AudBrou
force-pushed
the
task/fwms-946-remove-business-logic
branch
from
2165e70 to
d523e25
Compare
AudBrou
force-pushed
the
task/fwms-946-remove-business-logic
branch
from
d523e25 to
cf6823b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Je supprime la logique métier de vérification de la validité d'un EAN13 du design system.