Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

✨ hot and live reload #85

Merged
merged 2 commits into from
Jun 27, 2017
Merged

✨ hot and live reload #85

merged 2 commits into from
Jun 27, 2017

Conversation

bpetetot
Copy link
Contributor

#83

@bpetetot
Copy link
Contributor Author

@fabienjuif can you review those first steps of watch-mode implementation.
It's still missing the hot reloading of React components, but in order to implement it, I need to refactor the gui part and I would like to do it in an other PR.

FYI : Here the documentation of the new way to implement react-hot-loader

The old way to do it, is now deprecated

@bpetetot bpetetot requested a review from fabienjuif June 27, 2017 09:07
// output
targetProjectWebpack.output = {
path: path.resolve('..', '..', 'public'),
path: '/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are using webpack-dev-middleware, which put the output in memory.
So the path property doesn't have any impact.

Here, the documentation of webpack-dev-middleware explains :

app.use(webpackMiddleware(webpack({
	// webpack options
	// webpackMiddleware takes a Compiler object as first parameter
	// which is returned by webpack(...) without callback.
	entry: "...",
	output: {
		path: "/"
		// no real path is required, just pass "/"
		// but it will work with other paths too.
	}
})

Copy link
Contributor

@fabienjuif fabienjuif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, rest is good 👌

Copy link
Contributor

@fabienjuif fabienjuif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice work

@bpetetot bpetetot merged commit 06f860d into master Jun 27, 2017
@bpetetot bpetetot deleted the watch-mode branch June 27, 2017 10:20
bpetetot added a commit that referenced this pull request Jun 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants