-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
@fabienjuif can you review those first steps of watch-mode implementation. FYI : Here the documentation of the new way to implement react-hot-loader The old way to do it, is now deprecated |
// output | ||
targetProjectWebpack.output = { | ||
path: path.resolve('..', '..', 'public'), | ||
path: '/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are using webpack-dev-middleware
, which put the output in memory.
So the path
property doesn't have any impact.
Here, the documentation of webpack-dev-middleware
explains :
app.use(webpackMiddleware(webpack({
// webpack options
// webpackMiddleware takes a Compiler object as first parameter
// which is returned by webpack(...) without callback.
entry: "...",
output: {
path: "/"
// no real path is required, just pass "/"
// but it will work with other paths too.
}
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, rest is good 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 nice work
#83