Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-defined layout and devices based on user-defined enums #31

Closed
Zefau opened this issue Aug 15, 2020 · 15 comments
Closed

Add pre-defined layout and devices based on user-defined enums #31

Zefau opened this issue Aug 15, 2020 · 15 comments
Assignees
Labels
feature 🌟 Feature request or enhancement

Comments

@Zefau
Copy link
Owner

Zefau commented Aug 15, 2020

Supported adapters and device types:

Adapter light blinds socket heating
deconz x x
hue x x
hue-extended x x
shelly x x x
HomeMatic IP x x x x
@Zefau Zefau added the feature 🌟 Feature request or enhancement label Aug 15, 2020
@Zefau Zefau added this to the ROADMAP v1.0.0 milestone Aug 15, 2020
@Zefau Zefau self-assigned this Aug 15, 2020
@braindead1
Copy link

Your idea together with the possibility to automatically import alias devices would really improve and speed up the configuration of jarvis.

image

@Zefau
Copy link
Owner Author

Zefau commented Aug 17, 2020

Looks good. How do I activate the alias functionality? Is that a dedicated adapter? Couldn't find one and I'm missing the option in the menu. Found it.

@Zefau
Copy link
Owner Author

Zefau commented Aug 17, 2020

@braindead1 Actually looks like that the alias devices automatically added to the enums as well when assigned to a function? Can you confirm that?

I never worked with the alias / devices adapter. Is the structure flexible chosen by the user or is it statically set by the adapter based on deviceType ? First impression to me is, that it is static (which is good) and the user is not able to freely choose the name of the state?

@braindead1
Copy link

I just started using the adapter, but during the last ioBroker developer session it was discussed that the adapter could become part of the standard feature set. Therefore it is worth spending time. The intention of the adapter is to create a unified structure for devices of different adapters.

The answer to your question highly depends on the way aliases are created. If the alias is created with the mentioned adapter, the state names are given and cannot be changed by the users. Besides the adapter, aliases can be created manually (e.g. via scripts that can be found in the forum) and here the user is free to name states.

@Zefau
Copy link
Owner Author

Zefau commented Aug 30, 2020

This has been introduced now with v1.0.0-beta.1 and is ready for testing.

You will find the option to Import devices in the Devices tab of the configuration panel, see:
image

The following adapters are supported for a device import:
image

You may either search the whole adapter structure or filter to only search within (the user defined) enums.

@Zefau
Copy link
Owner Author

Zefau commented Aug 30, 2020

@braindead1 I would appreciate if you could test this functionality as well. Thanks for that!

@Zefau
Copy link
Owner Author

Zefau commented Aug 30, 2020

#41

@braindead1
Copy link

I removed my complete configuration to simulate a fresh installation of jarvis. I noticed the following:

  • The message "Please create the configuration. See documentation" is shown until the configuration is done. It should be possible to close this message manually. The message covers parts of the configuration dialog.

image

  • Newly imported devices should be ticked by default. Otherwise the user has to tick every device he wants to import. I have 51 alias devices and this was cumbersome.

  • All imported lights are handled like dimmers, meaning the SET state is transformed into level, which is not correct. I have a lot of dimmers, but the same amount of not dimmable lights.

  • It should be possible to disable the above mentioned transformation.

  • The above mentioned transformation should be improved to also set the Action for SET / level.

Other things I noticed that are not related to device import:

  • The "Abbrechen" button next to "Speichern" is pulsating until you click somewhere else. I was not able to take a screenshot to show what I mean as this effect is only available when the browser window has focus.

  • Saving "Page Settings" results in the following JSON: {"[object Object]":"Smart Home"}. I wanted to set the language to "Deutsch" and the title to "Smart Home".

@Zefau
Copy link
Owner Author

Zefau commented Aug 30, 2020

  • The message "Please create the configuration. See documentation" is shown until the configuration is done. It should be possible to close this message manually. The message covers parts of the configuration dialog. (fixed with 1.0.0-beta.2)
  • Newly imported devices should be ticked by default. Otherwise the user has to tick every device he wants to import. I have 51 alias devices and this was cumbersome.
  • All imported lights are handled like dimmers, meaning the SET state is transformed into level, which is not correct. I have a lot of dimmers, but the same amount of not dimmable lights. (fixed with 1.0.0-beta.8)
  • It should be possible to disable the above mentioned transformation.
  • The above mentioned transformation should be improved to also set the Action for SET / level. (fixed with 1.0.0-beta.8)
  • The "Abbrechen" button next to "Speichern" is pulsating until you click somewhere else. I was not able to take a screenshot to show what I mean as this effect is only available when the browser window has focus.
  • Saving "Page Settings" results in the following JSON: {"[object Object]":"Smart Home"}. I wanted to set the language to "Deutsch" and the title to "Smart Home". (fixed with 1.0.0-beta.2)

@Zefau
Copy link
Owner Author

Zefau commented Sep 4, 2020

It will not be possible to disable the state transformation. The created states can easily be removed. Furthermore, the "original" states will always be created / adapted as well.

@Zefau
Copy link
Owner Author

Zefau commented Sep 4, 2020

This should be resolved with 1.0.0-beta.2 respectively 1.0.0-beta.8.

@Zefau
Copy link
Owner Author

Zefau commented Sep 4, 2020

The "Abbrechen" button next to "Speichern" is pulsating until you click somewhere else. I was not able to take a screenshot to show what I mean as this effect is only available when the browser window has focus.

Could you explain in detail how to reproduce this? You are on the Device Import dialogue and you have searched for devices already and seeing the result list? And having the browser window focused the "Abbrechen" button is pulsating? What browser are you using?

@braindead1
Copy link

I have a clean installation of v1.0.0-beta.8 and no configuration. The config dialogue pops-up and now the "Abbrechen" button is pulsating until you click somewhere else. I tried Google Chrome and Microsoft Edge. In both browsers it's the same.

image

@Zefau
Copy link
Owner Author

Zefau commented Sep 4, 2020

#51

@Zefau Zefau closed this as completed Sep 4, 2020
@Zefau
Copy link
Owner Author

Zefau commented Sep 7, 2020

aa13283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🌟 Feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants