Use PyGithub to reuse auth headers to do requests #113
Conversation
bwrsandman
force-pushed
the
authenticated-requests
branch
2 times, most recently
from
367a47d
to
a2c3d14
Compare
|
@ZedThree this is probably the last set of large PRs for my needs |
|
Worth noting that you need specific permissions for an app installation
|
|
I tried getting the pr diff with |
| f"WARNING: Couldn't automatically download artifacts for workflow '{workflow_id}', response was: {r}: {r.reason}" | ||
| ) | ||
| return None, None | ||
| _, data = pull.repo._requester.requestJsonAndCheck( |
There was a problem hiding this comment.
Might be nice to retain the more specific error message if this fails?
| unposted_comments = set(map(lambda c: HashableComment(**c), review["comments"])) | ||
| posted_comments = set( | ||
| map(lambda c: HashableComment(**c), pull_request.get_pr_comments()) | ||
| ) | ||
|
|
||
| review["comments"] = [ | ||
| c.__dict__ for c in sorted(unposted_comments - posted_comments) | ||
| ] |
Is this something that still needs looking at, or is the PR ready as is? |
bwrsandman
force-pushed
the
authenticated-requests
branch
from
a2c3d14
to
baadf42
Compare
It's very minor. I wanted to reduce the custom API stuff but looks like it's needed here.
|
|
@ZedThree is there anything left to do ? |
Clean-up custom url creation and use PyGithub objects for that.
Use PyGithub checker function to catch 400+ codes.
This fixes app authenticated sessions losing the authentication for requests when downloading diffs and posting reviews.
This fixes
~/.netrcauthentication hijacking the authentication through the requests library.Re-use the hashable comment class to filter already posted comments