Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(mempool): Return verification result after attempting to insert transactions in the mempool #9067

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Dec 3, 2024

We want to merge this independently of #8951.

See #8901 for more details.

…t transactions in the mempool (#8901)

* respond with mempool verification result after a transaction has been inserted or has failed to be inserted into the mempool

* returns mempool verification errors early, and fixes handling for cancellations or timeouts.

* Adds a comment in test warning against code reuse with buffered services.
@arya2 arya2 added C-cleanup Category: This is a cleanup I-usability Zebra is hard to understand or use A-concurrency Area: Async code, needs extra work to make it work properly. A-mempool Area: Memory pool transactions P-High 🔥 labels Dec 3, 2024
@arya2 arya2 self-assigned this Dec 3, 2024
@arya2 arya2 requested review from a team as code owners December 3, 2024 17:36
@arya2 arya2 requested review from oxarbitrage and removed request for a team December 3, 2024 17:36
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 3, 2024
@conradoplg
Copy link
Collaborator

@Mergifyio queue

Copy link
Contributor

mergify bot commented Dec 4, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7561e1e

@mergify mergify bot merged commit 7561e1e into main Dec 4, 2024
145 of 146 checks passed
@mergify mergify bot deleted the mempool-verification-errors branch December 4, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-mempool Area: Memory pool transactions C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants