ref(docker): use cache mounts for build cache #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-devops
gustavovalverde
force-pushed
the
refactor-docker-caching
branch
2 times, most recently
from
a134823 to
99f1eb6
Compare
arya2
added
do-not-merge
gustavovalverde
force-pushed
the
refactor-docker-caching
branch
2 times, most recently
from
85ad65a to
bd923da
Compare
This update eliminates the need for external tools like `cargo-chef` to leverage caching layers, resulting in an average build time reduction of 4m30s (~36% improvement). While this solution doesn't fully resolve the issues mentioned in #6169 (comment), it represents the best possible approach without resorting to custom solutions, which we'd prefer to avoid.
gustavovalverde
force-pushed
the
refactor-docker-caching
branch
from
50d53ca to
2bd886c
Compare
|
@arya2 this one is ready now |
|
Do we want to close #6169 with this PR or are we planning on making any other improvements in the short term? |
|
I've just linked #6169, for automatic closure. This is not solving the underlying issue, but this is as far as we can get right now, until the |
mpguerra
approved these changes
Sep 5, 2024
dmidem
pushed a commit
to QED-it/zebra
that referenced
this pull request
Oct 29, 2024
* ref(docker): leverage cache mount with bind mounts This update eliminates the need for external tools like `cargo-chef` to leverage caching layers, resulting in an average build time reduction of 4m30s (~36% improvement). While this solution doesn't fully resolve the issues mentioned in ZcashFoundation#6169 (comment), it represents the best possible approach without resorting to custom solutions, which we'd prefer to avoid. * chore: remove extra `WORKDIR` and imp comments * chore: improve comment legibility Co-authored-by: Arya <[email protected]> --------- Co-authored-by: Pili Guerra <[email protected]> Co-authored-by: Arya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been using external tools and custom approaches to improve the caching layers in Rust, and avoid invalidating the caches if no Rust-code is changed.
This update eliminates the need for external tools like cargo-chef to leverage caching layers, resulting in an average build time reduction of 4m30s (~36% improvement).
While this solution doesn't fully resolve the issues mentioned in #6169 (comment), it represents the best possible approach without resorting to custom solutions, which we'd prefer to avoid.
Depends-On: #8817
Closes #6169
Specifications & References
Solution
cargo-chefrsyncstepsOthers
RUST_VERSIONarg so we don't invalidate our cache so frequently with Rust upgrades--linkin ourruntimestage, to reduce the resulting artifactTests
Follow-up Work
runtimestage with the root userPR Author's Checklist
PR Reviewer's Checklist