Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Increases timeout for non-blocking logger test #8462

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Apr 24, 2024

Motivation

I've seen this test timeout multiple times in the past couple days:
https://github.com/ZcashFoundation/zebra/actions/runs/8819285519/job/24210114095#step:12:7111

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Increase the timeout for waiting on the done notification in this test from 45 seconds to 90 seconds

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Optional ✨ labels Apr 24, 2024
@arya2 arya2 self-assigned this Apr 24, 2024
@arya2 arya2 requested a review from a team as a code owner April 24, 2024 18:18
@arya2 arya2 requested review from upbqdn and removed request for a team April 24, 2024 18:18
@arya2 arya2 changed the title increases timeout duration waiting on done notification in non-blocki… fix(test): Increases timeout for non-blocking logger test Apr 24, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this error as well, I hope it gets fixed by this change.

mergify bot added a commit that referenced this pull request Apr 24, 2024
@mergify mergify bot merged commit e95a70d into main Apr 24, 2024
137 checks passed
@mergify mergify bot deleted the increase-test-timeout branch April 24, 2024 20:28
@oxarbitrage oxarbitrage mentioned this pull request May 4, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Optional ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants