change(release): Adjust estimated release interval and end of support #8429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
added
A-release
oxarbitrage
requested review from
arya2 and
mpguerra
and removed request for
a team
|
Known test failure on Windows (#8461): https://github.com/ZcashFoundation/zebra/actions/runs/8820297906/job/24213599401#step:12:4731 |
|
@Mergifyio refresh |
✅ Pull request refreshed |
upbqdn
reviewed
May 6, 2024
mpguerra
reviewed
May 8, 2024
| @@ -22,7 +22,8 @@ pub const ESTIMATED_RELEASE_HEIGHT: u32 = 2_471_000; | |||
| /// | |||
| /// - Zebra will exit with a panic if the current tip height is bigger than the `ESTIMATED_RELEASE_HEIGHT` | |||
| /// plus this number of days. | |||
| pub const EOS_PANIC_AFTER: u32 = 112; | |||
There was a problem hiding this comment.
We should revert and possibly decrease this value to ensure that there are no zebra versions running with old consensus rules after the end of the current protocol version which includes the devfund.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the last Zebra team meeting we discussed to adjust the release interval to one every month instead of every 2 weeks or so.
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Extend the end of support from 16 weeks to 20 weeks and update the documents for doing release every 4 weeks instead of 2.
Testing
End of support tests remain working as they use the updated
EOS_PANIC_AFTERconstant.Review
@mpguerra might want to take a look at this, i can do changes if needed.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work