fix(scan): Fix minor concurrency bug in the scan gRPC method
#8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eys are sent on the watch channel
Joins register/subscribe scan service calls, sends SubscribeResults request first, and filters out duplicate results from channel
arya2
added
A-rpc
arya2
changed the title
scan gRPC methodscan gRPC method
9 tasks
idky137
pushed a commit
to idky137/zebra
that referenced
this pull request
Feb 28, 2024
…Foundation#8303) * update scan task to notify subscribe caller once the new subscribed_keys are sent on the watch channel * Fixes timing bug in scan gRPC method: Joins register/subscribe scan service calls, sends SubscribeResults request first, and filters out duplicate results from channel * Removes outdated TODO * wraps subscribed_keys in an Arc before sending to watch channel, fixes typo * Remove result senders for keys that have been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a follow up to #8268 and fixes an issue around missing results from a block in the
scangRPC method response.PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
subscribed_keyscollection and sending it to the watch channel (and sending it the result receiver)subscribed_keysin watch channel before writing results to storagescan()gRPC method to:ScanServicewith aSubscribeResultsrequest and to wait for the response before calling the scan service with aResultsrequestresult_receiverchannel to filter out any duplicates from theResultsresponseRelated cleanups:
RegisterKeysandSubscribeResultsservice call futuresReview
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
scan()method is present and unique