add(scan): Test the RegisterKeys scan service call
#8281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upbqdn
added
A-blockchain-scanner
github-actions
bot
added
the
C-trivial
upbqdn
changed the title
RegisterKeys scan service callRegisterKeys scan service call
upbqdn
force-pushed
the
test-registerkeys-service
branch
from
a9ff9a7 to
13c78f0
Compare
upbqdn
force-pushed
the
test-registerkeys-service
branch
from
a100faa to
69d1951
Compare
upbqdn
removed
the
C-trivial
arya2
reviewed
Feb 19, 2024
arya2
reviewed
Feb 19, 2024
arya2
reviewed
Feb 19, 2024
There was a problem hiding this comment.
This looks great, thank you for also updating the CHECK_INTERVAL.
I'm not sure about adding the strum crate, I think we should add our own code where needed to avoid reviewing the added dependency, but I like the idea of iterating through Network variants in tests. We may want to cleanup other tests that check both networks to iterator through the default variants before adding fields to the Testnet variant so that they won't need to be updated later.
github-actions
bot
added
the
C-trivial
Co-authored-by: Arya <[email protected]>
upbqdn
removed
the
C-trivial
github-actions
bot
added
the
C-trivial
upbqdn
removed
the
C-trivial
arya2
approved these changes
Feb 19, 2024
idky137
pushed a commit
to idky137/zebra
that referenced
this pull request
Feb 28, 2024
…#8281) * Impl generating continuous deserialized blocks * Make `sapling_efvk_hrp` `pub` * Don't wait for Sapling activation height in tests * Set the sleep interval for scan service to 10 secs * Simplify `sapling_key_to_scan_block_keys` * Enable mocking Sapling scanning keys for Testnet * Test the `RegisterKeys` scan service call * Enable `shielded-scan` for `zebra-chain` * Use an ephemeral database so results don't persist * Don't generate blocks when mocking the state * Improve error messages * Simplify seeding mocked Sapling viewing keys * Apply suggestions from code review Co-authored-by: Arya <[email protected]> * Use a manual iterator over `Network` --------- Co-authored-by: Arya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are missing tests for the
RegisterKeysservice call.PR Author Checklist
Check before marking the PR as ready for review:
Solution
This PR adds tests for
RegisterKeys, and contains a bunch of additional clean-ups:Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.