add(scan): Implement gRPC support for registering viewing keys for scanning

[upbqdn]

Motivation

Close #8176

PR Author Checklist

Check before marking the PR as ready for review:

• Will the PR name make sense to users?
• Does the PR have a priority label?
• Have you added or updated tests?
• Is the documentation up to date?

Solution

• Use use tonic::Request for consistency
• Add definitions of proto types
• Impl register_keys gRPC

Testing

We'll start with tests in #8244.

Reviewer Checklist

Check before approving the PR:

• Does the PR scope match the ticket?
• Are there enough tests to make sure it works? Do the tests cover the PR motivation?
• Are all the PR blockers dealt with?
  PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

• Add tests for gRPC methods #8244
• The version of Protocol Buffers in the Docker file is too old #8272

[oxarbitrage]

It seems we have a problem with the new optional field in the proto file https://github.com/ZcashFoundation/zebra/actions/runs/7888805960/job/21527160060?pr=8266#step:10:1572

[upbqdn]

We shouldn't see that error since Protocol Buffers v3.15.0, which was released back in 2021. Look at the first entry in the changelog: https://github.com/protocolbuffers/protobuf/releases/tag/v3.15.0. The issue describing the error was closed a long time ago: google/protobuf-gradle-plugin#415.

@gustavovalverde could you please have a look? It looks like we're using version pre 3.15.0?

[upbqdn]

I couldn't reproduce the error locally.

[upbqdn]

The error is:

protoc failed: proto/scanner.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.

[arya2]

Try using oneof with only one option, it worked for me earlier. (It's an issue with prost, not protoc)

Update: I was using an outdated version of protoc locally.

[upbqdn]

PR #8273 should resolve the issue.

[upbqdn]

PR #8273 should resolve the issue.

It did.

[arya2]

Could you show the manual test output?

[arya2]

Manual test output:

~/github/zebra$ grpcurl -plaintext -import-path ./zebra-grpc/proto -proto zebra-grpc/proto/scanner.proto -d '{"keys": [{ "key": "zxviews1q0duytgcqqqqpqre26wkl45gvwwwd706xw608hucmvfalr759ejwf7qshjf5r9aa7323zulvz6plhttp5mltqcgs9t039cx2d09mgq05ts63n8u35hyv6h9nc9ctqqtue2u7cer2mqegunuulq2luhq3ywjcz35yyljewa4mgkgjzyfwh6fr6jd0dzd44ghk0nxdv2hnv4j5nxfwv24rwdmgllhe0p8568sgqt9ckt02v2kxf5ahtql6s0ltjpkckw8gtymxtxuu9gcr0swvz" }]}' '127.0.0.1:8231' scanner.Scanner/RegisterKeys
{
  "keys": [
    "zxviews1q0duytgcqqqqpqre26wkl45gvwwwd706xw608hucmvfalr759ejwf7qshjf5r9aa7323zulvz6plhttp5mltqcgs9t039cx2d09mgq05ts63n8u35hyv6h9nc9ctqqtue2u7cer2mqegunuulq2luhq3ywjcz35yyljewa4mgkgjzyfwh6fr6jd0dzd44ghk0nxdv2hnv4j5nxfwv24rwdmgllhe0p8568sgqt9ckt02v2kxf5ahtql6s0ltjpkckw8gtymxtxuu9gcr0swvz"
  ]
}

Output for an already-registered key:

~/github/zebra$ grpcurl -plaintext -import-path ./zebra-grpc/proto -proto zebra-grpc/proto/scanner.proto -d '{"keys": ["zxviews1q0duytgcqqqqpqre26wkl45gvwwwd706xw608hucmvfalr759ejwf7qshjf5r9aa7323zulvz6plhttp5mltqcgs9t039cx2d09mgq05ts63n8u35hyv6h9nc9ctqqtue2u7cer2mqegunuulq2luhq3ywjcz35
yyljewa4mgkgjzyfwh6fr6jd0dzd44ghk0nxdv2hnv4j5nxfwv24rwdmgllhe0p8568sgqt9ckt02v2kxf5ahtql6s0ltjpkckw8gtymxtxuu9gcr0swvz"]}' '127.0.0.1:8231' scanner.Scanner/DeleteKeys
{}

[arya2]

Looks good!