-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add docker-compose
file to run CI locally
#8209
Merged
+186
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-devops
Area: Pipelines, CI/CD and Dockerfiles
I-usability
Zebra is hard to understand or use
C-testing
Category: These are tests
C-feature
Category: New features
P-Medium ⚡
labels
Jan 29, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jan 29, 2024
upbqdn
removed
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jan 29, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jan 29, 2024
arya2
force-pushed
the
ref-docker-features
branch
from
January 29, 2024 22:24
15a2777
to
384dee7
Compare
Co-authored-by: Arya <[email protected]>
This was
linked to
issues
Jan 30, 2024
arya2
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-feature
Category: New features
C-testing
Category: These are tests
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'd like to allow developers to run CI locally easily, using a similar approach to how we run it in our GitHub Actions, but without having to remember each specific command needed to run a specific test.
This would allow developers to confirm if an issue is specific to GitHub or GCP, or if it also reflects locally, and allow them to debug it easier.
Fixes #4464
Fixes #7534
This sets the ground for #8023
What are the most important goals of the ticket or PR?
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Complex Code or Requirements
Solution
docker-compose.test.yml
which can be used to run tests with a simple commandtest.env
file to avoid adding all these variables to the compose file.Testing
Review
The whole @ZcashFoundation/devops-reviewers should at least try this.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work