-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(scan): Create a tower Service in zebra-scan #8185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, i think we should add at least 1 test of the service but we can do it somewhere else. I will use the service, add a new request/response in the context of #8178 and will add a test there.
Motivation
This PR adds a
ScanService
struct tozebra-scan
to be used by RPC methods inzebra-grpc
.Closes #8182.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
ScanService
/ScanTask
structs andScanTaskCommand
enumRequest
andResponse
enums inzebra-node-services
tower::Service
forScanService
Storage
andScanTask
to fields onScanService
poll_ready()
methodRequest
variants and match arms incall()
methodReview
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
Implement match arms for
Request
variants