Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(devops): Explain how to change branch protection rules #7883

Merged
merged 4 commits into from
Nov 2, 2023
Merged

doc(devops): Explain how to change branch protection rules #7883

merged 4 commits into from
Nov 2, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

It's not clear how to change branch protection rules.

Close #7850

Solution

Add detailed admin instructions to the docs.

Review

@mpguerra might want to review this?

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 31, 2023
@teor2345 teor2345 self-assigned this Oct 31, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 31, 2023 01:10
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 31, 2023 01:10
mpguerra
mpguerra reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one link which needs updating

book/src/dev/continuous-integration.md Outdated Show resolved Hide resolved
@mpguerra mpguerra requested review from gustavovalverde and removed request for oxarbitrage October 31, 2023 09:40
@teor2345 @mpguerra
Fix incorrect link
b5b86f9 
Co-authored-by: Pili Guerra <[email protected]>
mpguerra
mpguerra approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mergify bot added a commit that referenced this pull request Nov 2, 2023
@mergify
Merge of #7883
3562ba0
@mergify mergify bot mentioned this pull request Nov 2, 2023
Closed
@mergify mergify bot merged commit 828c2ae into main Nov 2, 2023
68 checks passed
@mergify mergify bot deleted the doc-branch-prot branch November 2, 2023 16:59
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpguerra mpguerra mpguerra approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add step by step instructions for adding and removing branch protection rules
2 participants
@teor2345 @mpguerra