Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): grep the Zcash network correctly #7713

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix(ci): grep the Zcash network correctly #7713

merged 1 commit into from
Oct 10, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

Some tests fail to grep Zcash network: ${{ inputs.network }}, and fail, timeout or take longer than needed.

Solution

  • Use the same approach as in the Result of ${{ inputs.test_id }} test step, which is handling odd use cases nicely.

Review

  • Validate the startup logs take less than 1-2 minutes

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-hang A Zebra component stops responding to requests I-integration-fail Continuous integration fails, including build and test failures labels Oct 9, 2023
@gustavovalverde gustavovalverde self-assigned this Oct 9, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 9, 2023 22:08
@gustavovalverde gustavovalverde requested review from oxarbitrage and removed request for a team October 9, 2023 22:08
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 9, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

mergify bot added a commit that referenced this pull request Oct 9, 2023
@mergify mergify bot merged commit 9c12f7b into main Oct 10, 2023
115 checks passed
@mergify mergify bot deleted the fix-startup-logs branch October 10, 2023 00:49
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-hang A Zebra component stops responding to requests I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants