Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add $DISK_NAME to launch-without-cached-state #7709

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Oct 9, 2023

Motivation

Add missing string replacements missing from #7690, and add the $DISK_NAME variable when launching the container

Solution

  • Replace all /sbd with /$DISK_NAME
  • Add $DISK_NAME before docker run in launch-without-cached-state job

Review

Nothing specific

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ labels Oct 9, 2023
@gustavovalverde gustavovalverde self-assigned this Oct 9, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 9, 2023 19:29
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team October 9, 2023 19:29
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 9, 2023
@gustavovalverde gustavovalverde changed the title fix: use $DISK_NAME instead of hardcoded value fix: add $DISK_NAME to launch-without-cached-state Oct 9, 2023
@gustavovalverde
Copy link
Member Author

Running a full-sync here to confirm it starts running: https://github.com/ZcashFoundation/zebra/actions/runs/6461129131

We don't have to wait for this to finish, it's preferred to run the full sync from the main branch

@teor2345
Copy link
Contributor

teor2345 commented Oct 9, 2023

I've bumped this priority down to high so it doesn't interrupt other merging PRs.

@teor2345
Copy link
Contributor

teor2345 commented Oct 9, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

refresh

✅ Pull request refreshed

@teor2345
Copy link
Contributor

teor2345 commented Oct 9, 2023

This PR isn't being queued because this rule isn't satisfied:
all of: [📌 queue conditions of queue batched]
any of: [🛡 GitHub branch protection]
check-success=Zebra tip / Run full-sync-to-tip test

But I can see the patch job in the task list:
CI Docker / Zebra tip / Run full-sync-to-tip test (pull_request) Successful in 2s
Required
Details

@gustavovalverde this might be a weird mergify or workflow bug?

@gustavovalverde
Copy link
Member Author

@teor2345 I triggered a manual full-sync-to-tip from this branch, and it's still running. That might be the reason (?).

@gustavovalverde gustavovalverde merged commit 59ea5f1 into main Oct 10, 2023
130 checks passed
@gustavovalverde gustavovalverde deleted the disk-name-hotfix branch October 10, 2023 10:04
@teor2345
Copy link
Contributor

@teor2345 I triggered a manual full-sync-to-tip from this branch, and it's still running. That might be the reason (?).

That seems unlikely, manual syncs have never blocked merging before.

It could be a once-off Mergify bug.

@upbqdn upbqdn mentioned this pull request Oct 13, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants