-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add $DISK_NAME
to launch-without-cached-state
#7709
Conversation
$DISK_NAME
instead of hardcoded value$DISK_NAME
to launch-without-cached-state
Running a full-sync here to confirm it starts running: https://github.com/ZcashFoundation/zebra/actions/runs/6461129131 We don't have to wait for this to finish, it's preferred to run the full sync from the main branch |
I've bumped this priority down to high so it doesn't interrupt other merging PRs. |
@Mergifyio refresh |
✅ Pull request refreshed |
This PR isn't being queued because this rule isn't satisfied: But I can see the patch job in the task list: @gustavovalverde this might be a weird mergify or workflow bug? |
@teor2345 I triggered a manual full-sync-to-tip from this branch, and it's still running. That might be the reason (?). |
That seems unlikely, manual syncs have never blocked merging before. It could be a once-off Mergify bug. |
Motivation
Add missing string replacements missing from #7690, and add the $DISK_NAME variable when launching the container
Solution
/sbd
with/$DISK_NAME
docker run
inlaunch-without-cached-state
jobReview
Nothing specific
Reviewer Checklist