-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(docker): combine test and prod entrypoints into one #7660
Conversation
It might help to run a full sync with these script changes, to check that it works. But that's also a very slow test. What do you think? I don't mind either way, as long as the full sync is working on |
If other tests are passing, it should be the same behavior with the full sync. If my any means this causes an odd behavior (which I wouldn't expect) it should be quick to fix or revert. |
Ok, but the full sync hasn't passed since 1 September, before the self-hosted runners changes. So did you want to wait for a successful full sync on I am concerned we might end up with a stack of changes which might all contribute to the ongoing failures, and it's difficult to work out which ones are causing it. (Like we have in ticket #7618 in the Zebra Rust code right now!) |
Oh yeah, that's ok, this doesn't has to merged beforehand as we'll all be focusing on fixing the full sync test. In another note, the long-live instance is working. Here's the workflow run: https://github.com/ZcashFoundation/zebra/actions/runs/6386506331 |
acbffd8
to
fed758b
Compare
14a9a0b
to
6c7130f
Compare
899af4e
to
93c4077
Compare
This makes the following changes - Uses `-x` instead of echoing the variables values - Sets default values where required - Create a function to list directories - Create a function to run cargo tests - Use a better approach to handle different options in the `case` manegement for tests and production - Replaces all instances of `runtime-entrypoint.sh` with `entrypoint.sh`
10a65c3
to
a13831c
Compare
"A long lived instance must be deployed from this PR to validate CD configuration", but otherwise this PR looks great.
Motivation
Maintaining both entrypoint is not necessary, and having a single one help with refactors like:
Fixes: #7639
Complex Code or Requirements
Solution
-x
instead of echoing the variables valuescase
manegement for tests and productionruntime-entrypoint.sh
withentrypoint.sh
Review
Reviewer Checklist
Follow Up Work
Use arguments instead of variables, to run tests, based on the following comment: