Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Checking if transactions get into the mempool fails in lightwalletd tests #7644

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix(tests): Checking if transactions get into the mempool fails in lightwalletd tests #7644

merged 5 commits into from
Oct 10, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Sep 28, 2023 •
edited
Loading

Motivation

Zebra should be using the zcash/lightwalletd service.proto.

Close #7529.

Solution

  • Use updated service.proto from zcash/lightwalletd
    • Where height has been changed from -1 to 0, lightwalletd ignores that field anyways.

Related Cleanups:

  • Remove redundant truncate in test code

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 added P-Medium ⚡ C-testing Category: These are tests lightwalletd any work associated with lightwalletd A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Sep 28, 2023
@arya2 arya2 requested a review from a team as a code owner September 28, 2023 21:48
@arya2 arya2 self-assigned this Sep 28, 2023
@arya2 arya2 requested review from teor2345 and removed request for a team September 28, 2023 21:48
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Sep 28, 2023
teor2345
teor2345 previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix. Is there a way to avoid this mistake next time we update lightwalletd forks?

zebrad/tests/common/lightwalletd/send_transaction_test.rs Show resolved Hide resolved
zebrad/tests/common/lightwalletd/send_transaction_test.rs Show resolved Hide resolved
zebrad/tests/common/lightwalletd/proto/service.proto Show resolved Hide resolved
@arya2 arya2 requested a review from a team as a code owner September 29, 2023 00:43
@arya2 arya2 requested review from oxarbitrage and removed request for a team September 29, 2023 00:43
teor2345
teor2345 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks good to me but CI seems to be having issues.

teor2345
teor2345 suggested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test that this PR changes is still failing in CI, maybe we need to disable that part of the test:
https://github.com/ZcashFoundation/zebra/actions/runs/6433900141/job/17472517050?pr=7644#step:9:416

@arya2 arya2 force-pushed the fix-send-tx-test branch from e582b97 to 370821a Compare October 9, 2023 18:01
@teor2345 @arya2
Update docs
510998a 
Co-authored-by: Arya <[email protected]>
teor2345
teor2345 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to pass CI now

mergify bot added a commit that referenced this pull request Oct 10, 2023
@mergify
Merge of #7644
f01ff86
@mergify mergify bot mentioned this pull request Oct 10, 2023
Closed
@mergify mergify bot merged commit 931e0a7 into main Oct 10, 2023
@mergify mergify bot deleted the fix-send-tx-test branch October 10, 2023 02:00
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@arya2 arya2

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking if transactions get into the mempool fails in lightwalletd tests
2 participants
@arya2 @teor2345