Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devops): Long branch names fail CI because GCP resource name is too long #7643

Merged
merged 6 commits into from
Oct 11, 2023
Merged

fix(devops): Long branch names fail CI because GCP resource name is too long #7643

merged 6 commits into from
Oct 11, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Sep 28, 2023 •
edited by gustavovalverde
Loading

Motivation

Close #7559
Depends-On: #7616

Solution

  • Shorten long test ids

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

  • Do we want to use PR numbers instead of branch names?

@arya2 arya2 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures labels Sep 28, 2023
@arya2 arya2 self-assigned this Sep 28, 2023
@arya2 arya2 requested review from a team as code owners September 28, 2023 21:33
@arya2 arya2 requested review from gustavovalverde and oxarbitrage and removed request for a team September 28, 2023 21:33
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Sep 28, 2023
teor2345
teor2345 previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to allow an extra 2 characters in branch names, as suggested in the ticket.

.github/workflows/continous-integration-docker.patch.yml Outdated Show resolved Hide resolved
zebra-utils/README.md Outdated Show resolved Hide resolved
teor2345
teor2345 previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow changes look good, but CI is failing.

teor2345
teor2345 reviewed Oct 8, 2023
View reviewed changes
zebra-utils/README.md Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed Oct 8, 2023
View reviewed changes
zebra-utils/README.md Outdated Show resolved Hide resolved
teor2345
teor2345 suggested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs admin action for CI to work correctly after it merges.

@teor2345 teor2345 added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Oct 9, 2023
gustavovalverde
gustavovalverde approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gustavovalverde gustavovalverde merged commit b70556e into main Oct 11, 2023
134 checks passed
@gustavovalverde gustavovalverde deleted the short-gcp-resource-names branch October 11, 2023 19:17
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 requested changes

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@arya2 arya2

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devops: Long branch names fail CI because GCP resource name is too long
3 participants
@arya2 @teor2345 @gustavovalverde