Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(note-commitment-trees): Populate subtree fields in the NoteCommitmentTrees structs #7636

Merged
merged 10 commits into from
Oct 9, 2023
Merged

fix(note-commitment-trees): Populate subtree fields in the NoteCommitmentTrees structs #7636

merged 10 commits into from
Oct 9, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

The subtree fields of ZebraDb::note_commitment_trees() and Chain::update_chain_tip_with_block_parallel() are always None.

Close #7444

Solution

Populate fields when we have data.

Review

Open to suggestions, i was not able to figure out a quick way to add testing for this.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@oxarbitrage oxarbitrage requested a review from a team as a code owner September 27, 2023 21:09
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team September 27, 2023 21:09
@oxarbitrage

This comment was marked as resolved.

Sign in to view
teor2345

This comment was marked as resolved.

Sign in to view

teor2345
teor2345 previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

zebra-state/src/service/finalized_state/zebra_db/shielded.rs Outdated Show resolved Hide resolved
zebra-state/src/service/non_finalized_state/chain.rs Outdated Show resolved Hide resolved
This was referenced Oct 3, 2023
Closed
Closed
@teor2345
Copy link
Contributor

teor2345 commented Oct 8, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2023

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

mergify bot added a commit that referenced this pull request Oct 8, 2023
@mergify
Merge of #7636
c745d9f
@mergify mergify bot mentioned this pull request Oct 8, 2023
Closed
@teor2345
Copy link
Contributor

teor2345 commented Oct 9, 2023

@Mergifyio refresh

@teor2345
Copy link
Contributor

teor2345 commented Oct 9, 2023

Failed in the merge queue in PR #7692 due to issue #7659, I've re-queued it.

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Oct 9, 2023
@mergify
Merge of #7636
734af40
@mergify mergify bot mentioned this pull request Oct 9, 2023
Closed
@mergify mergify bot merged commit 1d45938 into main Oct 9, 2023
119 checks passed
@mergify mergify bot deleted the issue7444 branch October 9, 2023 02:02
@teor2345 teor2345 changed the title fix(note-commitment-trees): Populate subtrees fix(note-commitment-trees): Populate subtree fields in the NoteCommitmentTrees structs Oct 12, 2023
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 left review comments

@mpguerra mpguerra mpguerra left review comments

@teor2345 teor2345 teor2345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly populate subtree values in ZebraDb::note_commitment_trees()
4 participants
@oxarbitrage @teor2345 @mpguerra @arya2