Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Remove intermittent asserts in test #7600

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(test): Remove intermittent asserts in test #7600

merged 1 commit into from
Sep 21, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Close #7598

Solution

Remove intermittent asserts as at least a temporary fix.

Review

Anyone can review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

More research about this problem at #7529

@oxarbitrage oxarbitrage requested a review from a team as a code owner September 20, 2023 22:32
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team September 20, 2023 22:32
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Sep 20, 2023
teor2345
teor2345 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Sep 20, 2023
@teor2345 teor2345 added C-bug Category: This is a bug P-Medium ⚡ I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-concurrency Area: Async code, needs extra work to make it work properly. labels Sep 20, 2023
mergify bot added a commit that referenced this pull request Sep 21, 2023
@mergify
Merge of #7600
dce87ad
@mergify mergify bot mentioned this pull request Sep 21, 2023
Closed
@mergify mergify bot merged commit 09c1f99 into main Sep 21, 2023
@mergify mergify bot deleted the issue7598 branch September 21, 2023 03:20
@upbqdn upbqdn mentioned this pull request Sep 22, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@oxarbitrage oxarbitrage

Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable get_mempool_tx results in tests cause CI failures
2 participants
@oxarbitrage @teor2345