Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(doc): Add instructions for changing crate owners #7572

Merged
merged 5 commits into from
Sep 20, 2023
Merged

add(doc): Add instructions for changing crate owners #7572

merged 5 commits into from
Sep 20, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

Next time we change crate owners we want to make sure we don't miss anything.

Review

This is low-priority developer documentation.

Reviewer Checklist

  • Are the PR labels correct?
  • Do the scripts do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Sep 18, 2023
@teor2345 teor2345 self-assigned this Sep 18, 2023
@teor2345 teor2345 requested a review from a team as a code owner September 18, 2023 00:07
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team September 18, 2023 00:07
oxarbitrage
oxarbitrage approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you for creating it.

mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify
Merge of #7572
b8ca0fd
@mergify mergify bot mentioned this pull request Sep 20, 2023
Closed
@mergify mergify bot merged commit dbdb4be into main Sep 20, 2023
@mergify mergify bot deleted the doc-crate-own branch September 20, 2023 00:40
@upbqdn upbqdn mentioned this pull request Sep 22, 2023
Merged
38 tasks
arya2 pushed a commit that referenced this pull request Sep 29, 2023
@teor2345 @arya2
add(doc): Add instructions for changing crate owners (#7572)
346db0a 
* Add instructions for changing crate owners

* Explain new owner invites

* Remove duplicate `cargo login` instructions from the release checklist

* Remove owners as well

* Missing log line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @oxarbitrage