Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(docs): add missing elasticsearch flag feature to lib docs #7568

Merged
merged 2 commits into from
Sep 19, 2023
Merged

add(docs): add missing elasticsearch flag feature to lib docs #7568

merged 2 commits into from
Sep 19, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

It was noticed by @upbqdn here that the elasticsearch feafure is undocumented.

Solution

  • document the feature.
  • fix a small redundancy in the elasticsearch book page.

Review

Anyone can review, this is low priority.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@oxarbitrage oxarbitrage requested a review from a team as a code owner September 16, 2023 01:06
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team September 16, 2023 01:06
@oxarbitrage oxarbitrage self-assigned this Sep 16, 2023
@github-actions github-actions bot added the C-feature Category: New features label Sep 16, 2023
@oxarbitrage oxarbitrage added A-docs Area: Documentation P-Low ❄️ and removed C-feature Category: New features labels Sep 16, 2023
@oxarbitrage oxarbitrage mentioned this pull request Sep 16, 2023
Merged
6 tasks
@github-actions github-actions bot added C-feature Category: New features labels Sep 19, 2023
@oxarbitrage
Copy link
Contributor Author

The CI failed here by using a bad cache disk. The bad cache disk was now manually deleted and a re run here should pick another state from the list.

mergify bot added a commit that referenced this pull request Sep 19, 2023
@mergify
Merge of #7568
8d40c37
@mergify mergify bot mentioned this pull request Sep 19, 2023
Closed
@mergify mergify bot merged commit 920468c into main Sep 19, 2023
@mergify mergify bot deleted the elasticsearch-doc-fix branch September 19, 2023 23:04
arya2 pushed a commit that referenced this pull request Sep 29, 2023
@oxarbitrage @arya2
add elasticsearch to features flag doc (#7568)
2fb0bff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@upbqdn upbqdn upbqdn approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-docs Area: Documentation C-feature Category: New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxarbitrage @upbqdn @teor2345