Test z_getsubtreesbyindex using a lightwalletd gRPC request
#7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got bitten by this bug: tokio-rs/prost#332 when I added the enum `ShieldedProtocol` to the file `service.proto`. The problem is that `prost` implicitly derives `Eq` for enums, so deriving it explicitly via `type_attribute` causes a conflict. Lukily, there is another method `message_attribute` that operates only on messages and not enums.
upbqdn
added
P-Medium ⚡
C-testing
github-actions
bot
added
the
C-trivial
upbqdn
removed
the
C-trivial
github-actions
bot
added
the
C-trivial
upbqdn
commented
Sep 11, 2023
upbqdn
removed
the
C-trivial
arya2
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Add lightwalletd's protobuf types * Don't explicitly derive `Eq` for enums I got bitten by this bug: tokio-rs/prost#332 when I added the enum `ShieldedProtocol` to the file `service.proto`. The problem is that `prost` implicitly derives `Eq` for enums, so deriving it explicitly via `type_attribute` causes a conflict. Lukily, there is another method `message_attribute` that operates only on messages and not enums. * Test the `z_getsubtreesbyindex` RPC * Fix a typo * Add test vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #7451.
Specifications
I got the docs for the protobuf message types from https://github.com/zcash/lightwalletd/blob/8269810eeefac56ce326b0f6878c1ea3821b8ad5/docs/rtd/index.html.
Solution
GetSubtreeRootsRPC.I got bitten by this bug: tokio-rs/prost#332 when I added the enum
ShieldedProtocolto the fileservice.proto. The problem is thatprostimplicitly derivesEqfor enums, so deriving it explicitly viatype_attributecauses a conflict. Lukily, there is another methodmessage_attributethat operates only on messages and not enums.Review
Reviewer Checklist