Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(tools): Show zcash-cli version at the start of zcash-rpc-diff #7510

Merged
merged 3 commits into from
Sep 7, 2023
Merged

change(tools): Show zcash-cli version at the start of zcash-rpc-diff #7510

merged 3 commits into from
Sep 7, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 7, 2023

Motivation

We're seeing inconsistent behaviour from zcash-rpc-diff on different developers machines.

For example:
#7450 (comment)

Solution

  • Show the zcash-cli version when zcash-rpc-diff runs
  • Show the bash shell version when zcash-rpc-diff runs

Review

This is a low priority test tool change.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added P-Low ❄️ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Sep 7, 2023
@teor2345 teor2345 self-assigned this Sep 7, 2023
@teor2345 teor2345 requested a review from a team as a code owner September 7, 2023 20:47
@teor2345 teor2345 requested review from upbqdn and removed request for a team September 7, 2023 20:47
@teor2345 teor2345 mentioned this pull request Sep 7, 2023
Closed
oxarbitrage
oxarbitrage approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i like it. This will help to avoid some confusion as there are some differences between versions, for example #7450 (comment)

Just tested it and works.

mergify bot added a commit that referenced this pull request Sep 7, 2023
@mergify
Merge of #7510
8b85252
@mergify mergify bot mentioned this pull request Sep 7, 2023
Closed
@mergify mergify bot merged commit 6fc5db9 into main Sep 7, 2023
@mergify mergify bot deleted the show-zcash-cli-version branch September 7, 2023 22:13
@upbqdn upbqdn mentioned this pull request Sep 22, 2023
Merged
38 tasks
arya2 pushed a commit that referenced this pull request Sep 29, 2023
@teor2345 @arya2
change(tools): Show zcash-cli version at the start of zcash-rpc-diff (#…
30012d5 
…7510)

* Show zcash-cli version at the start of the script

* Show shell version and binary

* Move the versions to the top, above any possible RPC failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @oxarbitrage