Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(dev tools): Add node versions to zcash-rpc-diff #7453

Merged
merged 1 commit into from
Sep 5, 2023
Merged

change(dev tools): Add node versions to zcash-rpc-diff #7453

merged 1 commit into from
Sep 5, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 4, 2023 •
edited
Loading

Motivation

While I'm doing ticket #7450 it helps to see the node versions I'm using.

Close #7351.

Solution

  • Make ZCASHD and ZEBRAD include the node versions
  • Add new ZCASHD_NAME and ZEBRAD_NAME variables for the node names, which are used in file names

Testing

I manually tested these changes here:
#7450 (comment)

Review

This is a low priority developer-only change.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added P-Low ❄️ A-diagnostics Area: Diagnosing issues or monitoring performance C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Sep 4, 2023
@teor2345 teor2345 self-assigned this Sep 4, 2023
@teor2345 teor2345 requested a review from a team as a code owner September 4, 2023 02:24
@teor2345 teor2345 requested review from arya2 and removed request for a team September 4, 2023 02:24
oxarbitrage
oxarbitrage approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

mergify bot added a commit that referenced this pull request Sep 5, 2023
@mergify
Merge of #7453
085873d
@mergify mergify bot mentioned this pull request Sep 5, 2023
Closed
@mergify mergify bot merged commit 6274371 into main Sep 5, 2023
@mergify mergify bot deleted the zcash-rpc-diff-versions branch September 5, 2023 19:09
@upbqdn upbqdn mentioned this pull request Sep 22, 2023
Merged
38 tasks
arya2 pushed a commit that referenced this pull request Sep 29, 2023
@teor2345 @arya2
Add node versions to zcash-rpc-diff (#7453)
17c7aa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Zebra and zcashd versions to the output of zcash-rpc-diff
2 participants
@teor2345 @oxarbitrage