fix(ci): Make CD docker tests accept more progress logs #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
github-actions
bot
added
the
C-trivial
6 tasks
arya2
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Thank you!
This happened again in CI for this PR and was handled: https://github.com/ZcashFoundation/zebra/actions/runs/5386324293/jobs/9776624309?pr=7077#step:4:107
gustavovalverde
approved these changes
Jun 27, 2023
|
@Mergifyio refresh |
✅ Pull request refreshed |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The testnet tests look for Genesis progress, because sometimes that's the only block that can be downloaded on testnet.
But when testnet is running well, the node can get to BeforeOverwinter by the first progress log:
https://github.com/ZcashFoundation/zebra/actions/runs/5385468952/jobs/9774720826?pr=7035#step:5:80
https://github.com/ZcashFoundation/zebra/actions/runs/5385468952/jobs/9774720826?pr=7035#step:5:175
https://github.com/ZcashFoundation/zebra/actions/runs/5385468952/jobs/9774720826?pr=7035#step:5:187
Solution
This PR accepts either log.
Review
This is failing some PRs, so it is important to fix.
Reviewer Checklist