Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): Only show the Zebra logo & intro for the start command #7075

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

We don't need to show the logo when generating a config file.

Review

This is a usability fix, it is probably a release blocker.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug P-High 🔥 I-usability Zebra is hard to understand or use A-diagnostics Area: Diagnosing issues or monitoring performance labels Jun 27, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 27, 2023 03:51
@teor2345 teor2345 self-assigned this Jun 27, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 27, 2023 03:51
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team June 27, 2023 03:51
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #7075 (0bfdc3e) into main (3af03c3) will decrease coverage by 0.08%.
The diff coverage is 35.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7075      +/-   ##
==========================================
- Coverage   77.48%   77.40%   -0.08%     
==========================================
  Files         310      310              
  Lines       41720    41721       +1     
==========================================
- Hits        32326    32295      -31     
- Misses       9394     9426      +32     

Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for catching and fixing this. Looks good.

mergify bot added a commit that referenced this pull request Jun 27, 2023
@mergify mergify bot merged commit 6311cfb into main Jun 27, 2023
@mergify mergify bot deleted the logo-only-start-cmd branch June 27, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants