Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): Use correct cargo release manifest key name #7028

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

I used the wrong name for the cargo release version replacements table.

This makes cargo log an "unused manifest key: metadata" warning.

Specifications

The correct table name is package.metadata:
https://doc.rust-lang.org/cargo/reference/manifest.html#the-metadata-table

Testing

The warning disappears after this fix.

Review

This is a release blocker, but the other release blockers will take much longer to implement and merge.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Avoids an "unused manifest key: metadata" warning
@teor2345 teor2345 added C-bug Category: This is a bug P-Medium ⚡ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 21, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 21, 2023 00:16
@teor2345 teor2345 self-assigned this Jun 21, 2023
@teor2345 teor2345 requested review from arya2 and removed request for a team June 21, 2023 00:16
@teor2345 teor2345 added the A-release Area: Zebra releases and release management label Jun 21, 2023
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #7028 (f174b85) into main (56a7638) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7028      +/-   ##
==========================================
- Coverage   77.47%   77.38%   -0.10%     
==========================================
  Files         310      310              
  Lines       41647    41647              
==========================================
- Hits        32268    32228      -40     
- Misses       9379     9419      +40     

@teor2345
Copy link
Contributor Author

Failed due to #7015, but with the error "Failed to establish a new connection: [Errno 101] Network is unreachable":
https://github.com/ZcashFoundation/zebra/actions/runs/5328639930/jobs/9654625362?pr=7028#step:12:95

mergify bot added a commit that referenced this pull request Jun 21, 2023
@mergify mergify bot merged commit 17e14d9 into main Jun 21, 2023
@mergify mergify bot deleted the fix-unused-mainifest-key branch June 21, 2023 12:38
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release Area: Zebra releases and release management C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants