Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(release): Change network upgrade wording in release-checklist.md #7010

Merged
merged 1 commit into from
Jun 20, 2023
Merged

change(release): Change network upgrade wording in release-checklist.md #7010

merged 1 commit into from
Jun 20, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

Minor release checklist changes to make release levels clearer.

Review

@oxarbitrage asked for these in the engineering sync.

Reviewer Checklist

  • Are the PR labels correct?
  • Do the docs do what the ticket and PR says?

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 19, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 19, 2023 21:48
@teor2345 teor2345 self-assigned this Jun 19, 2023
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team June 19, 2023 21:48
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Jun 19, 2023
mpguerra
mpguerra approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mergify bot added a commit that referenced this pull request Jun 20, 2023
@mergify
Merge of #7010
43dc75a
@mergify mergify bot mentioned this pull request Jun 20, 2023
Closed
@mergify mergify bot merged commit ac4a342 into main Jun 20, 2023
@mergify mergify bot deleted the nu-release-checklist branch June 20, 2023 11:04
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpguerra mpguerra mpguerra approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @mpguerra